A sync between `stable-2.x` and `main` #2265

jiridanek · 2025-09-03T17:56:48Z

A sync between stable-2.x and main #2255

Summary by CodeRabbit

New Features
- Multi-arch builds enabled (arm64 + selected ppc64le/s390x) and a new multi-arch push pipeline.
- Build-args parameter support exposed to pipelines for per-image configuration.
Improvements
- Dockerfiles accept configurable base images; many moved from yum to dnf.
- CI/pipeline triggers refined to watch specific build-args files.
- Dependency bumps for key Jupyter components.
Chores
- Tekton task bundles and image digests refreshed.
- Removed obsolete CUDA repo and license files.

coderabbitai · 2025-09-03T17:56:54Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

main
2024b

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Adds a multi-arch Tekton push pipeline, updates many PipelineRun YAMLs to add build-args-file and multi-arch build-platforms/CEL triggers, parameterizes many Dockerfiles via ARG BASE_IMAGE with new build-args/*.conf files, replaces yum→dnf in base-images, refreshes many task/image digests, and updates Makefile and generation scripts.

Changes

Cohort / File(s)	Summary
Tekton pipelines & bundles `.tekton/multiarch-push-pipeline.yaml`, `.tekton/multiarch-pull-request-pipeline.yaml`, `.tekton/singlearch-push-pipeline.yaml`	Added new multiarch push Pipeline; updated bundle image sha256 digests (task bundle replacements) with no task graph changes.
PipelineRun param / trigger edits (many files) `.tekton/-push.yaml`, `.tekton/-pull-request.yaml` (multiple under .tekton/...)	Switched many push PipelineRuns to `multiarch-push-pipeline`, added `build-platforms` (multi-arch) and `build-args-file` params; consolidated/updated `pipelinesascode.tekton.dev/on-cel-expression` pathChanged() entries to include build-args files.
Makefile + pipeline PR generation `Makefile`, `scripts/generate_pull_request_pipelineruns.py`	Makefile: detect per-Dockerfile build-args conf and construct --build-arg flags; PR generator: propagate params into PR PipelineRun template (signature change).
Dockerfiles: base parameterization (CPU & others) multiple CPU Dockerfiles (e.g., `codeserver/.../Dockerfile.cpu`, `jupyter//Dockerfile.cpu`, `rstudio/.../Dockerfile.cpu`, `runtimes//Dockerfile.cpu`)	Added `ARG BASE_IMAGE`, introduced cpu-base (or equivalent) stage, and updated downstream stages to use the new base stage.
Dockerfiles: CUDA/ROCm simplification & base param many CUDA/ROCm Dockerfiles (e.g., `jupyter//Dockerfile.cuda`, `runtimes//Dockerfile.cuda`, `jupyter/rocm/*/Dockerfile.rocm`, `runtimes/rocm-/**/Dockerfile.rocm`)	Added `ARG BASE_IMAGE`; removed in-Dockerfile multi-arch CUDA/ROCm base scaffolding and in-image installs in many files, relying on external BASE_IMAGE; some ROCm/CUDA-specific files adjusted or retained minimal tooling.
Add build-args config files `*/build-args/.conf` (new files across codeserver, jupyter, runtimes, rstudio, etc.)	New per-image build-args files (e.g., `BASE_IMAGE=...`) added to provide BASE_IMAGE values for CPU/CUDA/ROCm variants.
Base-images: yum → dnf `base-images/cuda/12.6//Dockerfile.cuda`, `base-images/rocm/6.2//Dockerfile.rocm`	Replaced `yum` commands with `dnf` equivalents in multiple base-image Dockerfiles; minor WORKDIR addition.
Image digests & manifests `manifests/base/params-latest.env`	Updated multiple py312 image sha256 digests.
Removed CUDA license & repo files `cuda/NGC-DL-CONTAINER-LICENSE`, `cuda/cuda.repo-amd64`, `cuda/cuda.repo-arm64`	Deleted CUDA license and cuda.repo files.
Tests & CI `tests/manifests.py`, `ci/cached-builds/gen_gha_matrix_jobs.py`	tests: adjusted RStudio path selection for non-py312 to CUDA buildconfig; CI: added datascience runtime targets to S390X compatibility list.
Python deps / examples `jupyter/rocm/tensorflow/.../pylock.toml`, `pyproject.toml`, `examples/jupyterlab-with-elyra/Dockerfile`	Dependency/version bumps (Jupyter/Elyra/skl2onnx) and pylock/pyproject updates.
Utility scripts `jupyter/utils/install_pdf_deps.sh`	Skip PDF deps installer on `s390x` and `ppc64le`; message reports actual arch.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60–90 minutes

Possibly related issues

Optimize CUDA Dockerfiles by removing redundant upgrade commands #1913 — Modifies CUDA Dockerfiles and package handling (yum→dnf / CUDA base changes); this PR similarly refactors CUDA base stages and package management.

Possibly related PRs

Refactor Dockerfiles to Use Config Files via ARG #2271 — Strong overlap: BASE_IMAGE ARG refactors, build-args-file plumbing, and Makefile/pipeline propagation changes.
Issue #2157: chore(Dockerfiles): replace yum with dnf consistently across UBI9 Dockerfiles #2185 — Related changes converting yum→dnf across CUDA/ROCm Dockerfiles.
RHOAIENG-31406: enable Runtime Datascience Images for IBM Z[s390x] (Python 3.12) #1513 — Related to s390x enablement for runtime-datascience (Dockerfile, pylock markers, CI S390X list, pipeline build-platforms).

Suggested reviewers

dibryant
daniellutz

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2025-09-03T17:56:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andyatmiami for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…pilines

…rgs-file option and run it to update them all

…tween imagestreams (#2260)

…sent from aipcc bases (#2413) ``` npm notice package-lock.json has been renamed to npm-shrinkwrap.json npm notice package-lock.json has been renamed to npm-shrinkwrap.json npm notice package-lock.json has been renamed to npm-shrinkwrap.json ./ci/lib.sh: line 44: rsync: command not found subprocess exited with status 127 subprocess exited with status 127 Error: building at STEP "RUN ./get_code_server_rpm.sh && touch /tmp/control": exit status 127 ```

… after 2025b reorg (#2416)

…k imagestream to align with the lock file for the image (#2416)

…lock dependencies (#2418)

… absent from aipcc bases (#2419) ``` done (release-packages/code-server-4.98.0-linux-arm64) ./ci/build/build-packages.sh: line 57: envsubst: command not found Error: building at STEP "RUN ./get_code_server_rpm.sh && touch /tmp/control": while running runtime: exit status 127 ```

* RHOAIENG-33887: Release Elyra 4.2.4 * pylock update

…Studio Dockerfiles to address CVE-2025-4674

originally introduced in * #940

…command in GitHub Actions workflow (#2407) * combine multiple `apt-get remove` patterns into a single command in GitHub Actions workflow * use `apt-get purge` instead of `remove` in GitHub Actions to clean dependencies completely

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>

forward-ports the changes from our good IBM fellow engineers * red-hat-data-services#1539 * red-hat-data-services#1560

jiridanek added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Sep 3, 2025

openshift-ci bot requested review from atheo89 and dibryant September 3, 2025 17:56

github-actions bot added the review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel label Sep 3, 2025

openshift-ci bot added size/s size/xl and removed size/s labels Sep 3, 2025

atheo89 and others added 13 commits September 4, 2025 09:36

Update pytorch_llmcompressor and its runtime as well as the tekton pi…

6027bcf

…pilines

Update pytorch rocm and its runtime as well as the tekton pipelines

dbb5ee5

Update tensorflow-rocm and its runtime as well as the tekton pipilines

23b1046

Update tensorflow and its runtime as well as the tekton pipelines

f224482

Update trusty and its tekton pipeline

e06b68c

Update codeserver as well as its pipeline

2270a47

Update RStudio c9s flavos and its pipelines

f71bc18

Update the generate_pull_request_pipelineruns.py to track the build-a…

d31d423

…rgs-file option and run it to update them all

clean up from unused commands

a742c56

configuration ARGs should be on the top level on the Dockerfile

8134f76

Update base images with the real odh base images

d0fccc2

Fix path on runtime minimal conf file

904bf23

RHAIENG-308, #2242: tests(make): enforce version parity validation be…

a7b8f66

…tween imagestreams (#2260)

openshift-ci bot added size/xl and removed size/xl labels Sep 4, 2025

jiridanek changed the title ~~A sync between stable-2.x and main~~ A sync between stable-2.x and main Sep 4, 2025

openshift-ci bot added size/xl and removed size/xl labels Sep 4, 2025

Recomented fixes noted by code rabit

798bfe2

openshift-ci bot added size/xxl and removed size/xxl labels Sep 11, 2025

jiridanek added 2 commits September 11, 2025 14:59

fixup(tests): update manifest path determination logic for test cases…

e737ef2

… after 2025b reorg (#2416)

chore(manifests): update package versions in Jupyter TrustyAI noteboo…

ff8e28e

…k imagestream to align with the lock file for the image (#2416)

openshift-ci bot added size/xxl and removed size/xxl labels Sep 11, 2025

chore(manifests): update package version of Codeflare-SDK (0.31) and …

2f79a27

…lock dependencies (#2418)

openshift-ci bot added size/xxl and removed size/xxl labels Sep 11, 2025

RHOAIENG-33887: Update Elyra to latest version (4.2.4) (#2430)

4294afa

* RHOAIENG-33887: Release Elyra 4.2.4 * pylock update

openshift-ci bot added size/xxl and removed size/xxl labels Sep 12, 2025

jiridanek added 2 commits September 12, 2025 10:17

RHAIENG-987: remove skopeo and OpenShift client installation from R…

35924c8

…Studio Dockerfiles to address CVE-2025-4674

fix(tests): remove stray oc version call in tests

08d2c1f

originally introduced in * #940

openshift-ci bot added size/xxl and removed size/xxl labels Sep 12, 2025

chore(deps): update konflux references (#2341)

e834e28

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>

openshift-ci bot added size/xxl and removed size/xxl labels Sep 12, 2025

s390x(jupyter/datascience): make image buildable on s390x (#2432)

e3425fb

forward-ports the changes from our good IBM fellow engineers * red-hat-data-services#1539 * red-hat-data-services#1560

openshift-ci bot added size/xxl and removed size/xxl labels Sep 12, 2025

jiridanek merged commit e3425fb into stable-2.x Sep 12, 2025
32 of 78 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

A sync between `stable-2.x` and `main` #2265

A sync between `stable-2.x` and `main` #2265

Uh oh!

jiridanek commented Sep 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 3, 2025 •

edited

Loading

Review skipped

Uh oh!

openshift-ci bot commented Sep 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

A sync between stable-2.x and main #2265

A sync between stable-2.x and main #2265

Uh oh!

Conversation

jiridanek commented Sep 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Possibly related PRs

Suggested reviewers

Uh oh!

openshift-ci bot commented Sep 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

A sync between `stable-2.x` and `main` #2265

A sync between `stable-2.x` and `main` #2265

jiridanek commented Sep 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 3, 2025 •

edited

Loading